Skip to content

Commit

Permalink
Comment cleanup.
Browse files Browse the repository at this point in the history
  • Loading branch information
dholladay00 committed Apr 5, 2023
1 parent ff93980 commit f470751
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
3 changes: 1 addition & 2 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,7 @@ include(content)
spiner_content_declare(ports-of-call
NAMESPACE spinerDeps
GIT_REPO https://github.com/lanl/ports-of-call
# NOTE: main as of Nov. 28 2022
#GIT_TAG 3fffe08408b1ee754d0567a3de63cb47ce97d9f7
# most recent relase as of April 05, 2023
GIT_TAG v1.5.1
)

Expand Down
3 changes: 1 addition & 2 deletions spiner/databox.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,6 @@ class DataBox {
return indices_[i];
}

// TODO(JMM): Add more code for more portability strategies
DataBox<T> getOnDevice() const { // getOnDevice is always a deep copy
// create device memory (host memory if no device)
T *device_data = (T *)PORTABLE_MALLOC(sizeBytes());
Expand All @@ -303,7 +302,7 @@ class DataBox {
// create new databox of size size
DataBox<T> a{device_data, dim(6), dim(5), dim(4), dim(3), dim(2), dim(1)};
a.copyShape(*this);
// this may need logic for if host? JMM thoughts?
// set correct allocation status of the new databox
if (PortsOfCall::EXECUTION_IS_HOST) {
a.status_ = DataStatus::AllocatedHost;
} else {
Expand Down

0 comments on commit f470751

Please sign in to comment.