move sql-only functions to plpgsql instead of using SPI #361
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
Hi! Looks like you've reached your API usage limit. You can increase it from your account settings page here: app.greptile.com/settings/usage
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
lantern_extras/src/daemon.rs
Outdated
| CREATE OR REPLACE FUNCTION get_embedding_job_status(job_id INT) | ||
| RETURNS TABLE (status TEXT, progress SMALLINT, error TEXT) | ||
| STRICT IMMUTABLE PARALLEL SAFE | ||
| SECURITY DEFINER |
There was a problem hiding this comment.
why do these need to be security definer?
There was a problem hiding this comment.
the embedding jobs table is being created mostly by superusers and then when regular user tries to call the get_embedding_job_status or related function it does not have permission to read from the table.
There was a problem hiding this comment.
Can't we grant SELECT on the jobs table to PUBLIC instead?
There was a problem hiding this comment.
you are correct, I did grant select to public already. Added tests to make sure that functions work without security definer.
…ready grant select to public for underlying tables
No description provided.