Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve install command #258

Merged
merged 1 commit into from
Feb 16, 2024
Merged

improve install command #258

merged 1 commit into from
Feb 16, 2024

Conversation

atmonshi
Copy link
Member

No description provided.

Copy link

what-the-diff bot commented Feb 16, 2024

PR Summary

  • Changes to Command Execution Method in InstallCommand.php File
    The method to execute certain commands has been modified. Previously, these commands were executed silently (due to the use of callSilent method). Now, they are executed in a way that provides feedback (using the call method). This change affects activities such as publishing migrations and assets, as well as running migrations.

  • Addition of Success Message Post-Installation
    Following the successful installation, a new success message has been included. This message also encourages users to star the package on Filament's site to appreciate our work. This can potentially improve user engagement and increase popularity of the package.

@atmonshi atmonshi merged commit 1818bbd into 3.x Feb 16, 2024
5 checks passed
@atmonshi atmonshi deleted the imporve-command branch February 16, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant