Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conditional visibility when relying on a toggle field being false #339

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

holmesadam
Copy link
Contributor

Scenario:

Field A: Toggle Field
Field B: Text Field with conditional visibility when Field A is Not Checked.

With the above scenario the in_array function at line 146 does not return true because we're comparing a string "false" from the database (visibility options) with a boolean false from the related toggle field.

Converting the boolean fields to strings here solves that issue.

Copy link

what-the-diff bot commented Dec 19, 2024

PR Summary

  • Incorporated a Mapping Function for Easier Comparison
    Our team has integrated a new function that transforms Boolean values (true or false) into corresponding string representations. This addition is aimed at simplifying comparison tasks within the appendFilamentComponentsOptions method, contributing toward more efficient code execution.

@atmonshi atmonshi merged commit c011d2f into lara-zeus:3.x Dec 24, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants