Update MarkdownEditor.php

[albertobenavides]

Replaced with RichEditor from filamentphp

[atmonshi]

Thank you :)
However, some are still using the markdown editor. Are there any issues with it to replace it?

you can add a new editor to your app or submit a new PR :)

[albertobenavides]

Hello :) The Markdown Editor is not compatible for filament 3. Thats why I have update and use the one in filament.

[albertobenavides]

I know we can add a new editor, but I like the simple markdown editor for most of purposes.

[atmonshi]

ok, good point.
the 'rich-editor' will return HTML I think, not markdown, so the render function should be changed?

I think it's better to use:
https://filamentphp.com/docs/3.x/forms/fields/markdown-editor
(render markdown)

and create another one for:
https://filamentphp.com/docs/3.x/forms/fields/rich-editor
(render html)

[albertobenavides]

@atmonshi, I am using rich-editor without a problem (no render or further changes needed). But, as you stated, I think having both options is better

[atmonshi]

Using it for a new project won't affect a thing, but when someone upgrades the old posts won't rendered correctly either on the editor admin page or on the FE :)
it all comes down to how the markup is stored in the DB, markdown or HTML.

[albertobenavides]

Using it for a new project won't affect a thing, but when someone upgrades the old posts won't rendered correctly either on the editor admin page or on the FE :) it all comes down to how the markup is stored in the DB, markdown or HTML.

Oh, I get what you said, but you can always use {!! $some_html !!} to render HTML in Laravel apps. So that should not be a problem at all.

[atmonshi]

you can always use {!! $some_html !!} to render HTML in Laravel

yes I know :), but we also have parsers and skipper it's not just the content. anyway, will work on this and release it with v3.1 soon

thank you again :).

[albertobenavides]

Thank you! Keep the good work going. I'll try to help any time I can :B