-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axing persistent decorators #27
base: master
Are you sure you want to change the base?
Conversation
Hmm - I'm not sure I like the idea of 'undecorate'. I'll see if I can make it reset every time. |
Yeah, I had a hard time coming up with a name :-)
|
Hey Jeff, Do you have any tips on how to run multiple commands with their own decorators in one controller action? It does not seem to be possible. The second command hits the decorators of the first. Please let us know or consider this pull request please. |
@JeffreyWay Would you be okay with @aarongustafson Can you update the pull request to fix the merge conflicts (looks like just a comment has changed)? Also, you don't have to do |
I really need this fix? when will it be merged? |
Related to this issue I found another but. when for example foreaching a collection en in that foreach you have a command executed with a decorated the command itself get's multiplied. so first 1 command, second 2 commands, third item 3 commands, etc etc.. |
+1. I just go into the same problem, will this be fixed? |
I tweaked the method name and the conditional. |
This pull request fixes #22.