Merge pull request #1 from laravel-admin-extensions/analysis-Xar4a0

Apply fixes from StyleCI
laravel-admin-extensions · Apr 13, 2018 · 0d2449f · 0d2449f
2 parents bac830c + 8b7d0ab
commit 0d2449f
Show file tree

Hide file tree

Showing 10 changed files with 60 additions and 54 deletions.
diff --git a/src/BootExtension.php b/src/BootExtension.php
@@ -45,4 +45,4 @@ public static function import()
 
         parent::createPermission('Redis Manager', 'ext.redis-manager', 'redis*');
     }
-}
+}
diff --git a/src/DataType/DataType.php b/src/DataType/DataType.php
@@ -33,26 +33,30 @@ public function getConnection()
 
     /**
      * @param string $key
+     *
      * @return mixed
      */
-    public abstract function fetch(string $key);
+    abstract public function fetch(string $key);
 
     /**
      * @param array $params
+     *
      * @return mixed
      */
-    public abstract function update(array $params);
+    abstract public function update(array $params);
 
     /**
      * @param array $params
+     *
      * @return mixed
      */
-    public abstract function store(array $params);
+    abstract public function store(array $params);
 
     /**
      * Returns the remaining time to live of a key that has a timeout.
      *
      * @param string $key
+     *
      * @return int
      */
     public function ttl($key)
@@ -64,7 +68,7 @@ public function ttl($key)
      * Set a timeout on key.
      *
      * @param string $key
-     * @param integer $expire
+     * @param int    $expire
      *
      * @return void
      */
@@ -82,4 +86,4 @@ public function setTtl($key, $expire)
             $this->getConnection()->persist($key);
         }
     }
-}
+}
diff --git a/src/DataType/Hashes.php b/src/DataType/Hashes.php
@@ -20,7 +20,6 @@ public function update(array $params)
         $key = array_get($params, 'key');
 
         if (array_has($params, 'field')) {
-
             $field = array_get($params, 'field');
             $value = array_get($params, 'value');
 
@@ -40,10 +39,10 @@ public function update(array $params)
      */
     public function store(array $params)
     {
-        $key    = array_get($params, 'key');
-        $ttl    = array_get($params, 'ttl');
-        $field  = array_get($params, 'field');
-        $value  = array_get($params, 'value');
+        $key = array_get($params, 'key');
+        $ttl = array_get($params, 'ttl');
+        $field = array_get($params, 'field');
+        $value = array_get($params, 'value');
 
         $this->getConnection()->hset($key, $field, $value);
 
@@ -61,13 +60,14 @@ public function store(array $params)
      * Remove a field from a hash.
      *
      * @param array $params
+     *
      * @return int
      */
     public function remove(array $params)
     {
-        $key   = array_get($params, 'key');
+        $key = array_get($params, 'key');
         $field = array_get($params, 'field');
 
         return $this->getConnection()->hdel($key, [$field]);
     }
-}
+}
diff --git a/src/DataType/Lists.php b/src/DataType/Lists.php
@@ -20,7 +20,6 @@ public function update(array $params)
         $key = array_get($params, 'key');
 
         if (array_has($params, 'push')) {
-
             $item = array_get($params, 'item');
             $command = $params['push'] == 'left' ? 'lpush' : 'rpush';
 
@@ -40,9 +39,9 @@ public function update(array $params)
      */
     public function store(array $params)
     {
-        $key    = array_get($params, 'key');
-        $item  = array_get($params, 'item');
-        $ttl    = array_get($params, 'ttl');
+        $key = array_get($params, 'key');
+        $item = array_get($params, 'item');
+        $ttl = array_get($params, 'ttl');
 
         $this->getConnection()->rpush($key, [$item]);
 
@@ -60,11 +59,12 @@ public function store(array $params)
      * Remove a member from list by index.
      *
      * @param array $params
+     *
      * @return mixed
      */
     public function remove(array $params)
     {
-        $key   = array_get($params, 'key');
+        $key = array_get($params, 'key');
         $index = array_get($params, 'index');
 
         $lua = <<<'LUA'
@@ -74,4 +74,4 @@ public function remove(array $params)
 
         return $this->getConnection()->eval($lua, 1, $key, $index);
     }
-}
+}
diff --git a/src/DataType/Sets.php b/src/DataType/Sets.php
@@ -40,9 +40,9 @@ public function update(array $params)
      */
     public function store(array $params)
     {
-        $key    = array_get($params, 'key');
-        $ttl    = array_get($params, 'ttl');
-        $members  = array_get($params, 'members');
+        $key = array_get($params, 'key');
+        $ttl = array_get($params, 'ttl');
+        $members = array_get($params, 'members');
 
         $this->getConnection()->sadd($key, $members);
 
@@ -60,13 +60,14 @@ public function store(array $params)
      * Remove a member from a set.
      *
      * @param array $params
+     *
      * @return int
      */
     public function remove(array $params)
     {
-        $key    = array_get($params, 'key');
+        $key = array_get($params, 'key');
         $member = array_get($params, 'member');
 
         return $this->getConnection()->srem($key, $member);
     }
-}
+}
diff --git a/src/DataType/SortedSets.php b/src/DataType/SortedSets.php
@@ -9,7 +9,7 @@ class SortedSets extends DataType
      */
     public function fetch(string $key)
     {
-        return $this->getConnection()->zrange($key,0, -1, ['WITHSCORES' => true]);
+        return $this->getConnection()->zrange($key, 0, -1, ['WITHSCORES' => true]);
     }
 
     public function update(array $params)
@@ -23,8 +23,7 @@ public function update(array $params)
         }
 
         if (array_has($params, '_editable')) {
-
-            $score  = array_get($params, 'value');
+            $score = array_get($params, 'value');
             $member = array_get($params, 'pk');
 
             $this->getConnection()->zadd($key, [$member => $score]);
@@ -36,10 +35,10 @@ public function update(array $params)
      */
     public function store(array $params)
     {
-        $key    = array_get($params, 'key');
-        $ttl    = array_get($params, 'ttl');
-        $score  = array_get($params, 'score');
-        $member  = array_get($params, 'member');
+        $key = array_get($params, 'key');
+        $ttl = array_get($params, 'ttl');
+        $score = array_get($params, 'score');
+        $member = array_get($params, 'member');
 
         $this->getConnection()->zadd($key, [$member => $score]);
 
@@ -57,13 +56,14 @@ public function store(array $params)
      * Remove a member from a sorted set.
      *
      * @param array $params
+     *
      * @return int
      */
     public function remove(array $params)
     {
-        $key   = array_get($params, 'key');
+        $key = array_get($params, 'key');
         $member = array_get($params, 'member');
 
         return $this->getConnection()->zrem($key, $member);
     }
-}
+}
diff --git a/src/DataType/Strings.php b/src/DataType/Strings.php
@@ -25,9 +25,9 @@ public function update(array $params)
      */
     public function store(array $params)
     {
-        $key    = array_get($params, 'key');
-        $value  = array_get($params, 'value');
-        $ttl    = array_get($params, 'ttl');
+        $key = array_get($params, 'key');
+        $value = array_get($params, 'value');
+        $ttl = array_get($params, 'ttl');
 
         $this->getConnection()->set($key, $value);
 
@@ -36,7 +36,7 @@ public function store(array $params)
         }
 
         return redirect(route('redis-index', [
-            'conn' => request('conn')
+            'conn' => request('conn'),
         ]));
     }
-}
+}
diff --git a/src/RedisController.php b/src/RedisController.php
@@ -11,14 +11,13 @@
 class RedisController extends BaseController
 {
     /**
-     * Index page
+     * Index page.
      *
      * @return Content
      */
     public function index()
     {
         return Admin::content(function (Content $content) {
-
             $content->header('Redis manager');
             $content->description('Connections');
             $content->breadcrumb(['text' => 'Redis manager']);
@@ -51,7 +50,6 @@ public function index()
     public function edit(Request $request)
     {
         return Admin::content(function (Content $content) use ($request) {
-
             $connection = $request->get('conn', 'default');
 
             $manager = $this->manager();
@@ -80,15 +78,15 @@ public function edit(Request $request)
     }
 
     /**
-     * Create page
+     * Create page.
      *
      * @param Request $request
+     *
      * @return Content
      */
     public function create(Request $request)
     {
         return Admin::content(function (Content $content) use ($request) {
-
             $connection = $request->get('conn', 'default');
 
             $manager = $this->manager();
@@ -136,6 +134,7 @@ public function destroy(Request $request)
 
     /**
      * @param Request $request
+     *
      * @return array
      */
     public function fetch(Request $request)
@@ -145,6 +144,7 @@ public function fetch(Request $request)
 
     /**
      * @param Request $request
+     *
      * @return mixed
      */
     public function remove(Request $request)
@@ -156,6 +156,7 @@ public function remove(Request $request)
 
     /**
      * @param Request $request
+     *
      * @return mixed
      */
     public function update(Request $request)
@@ -173,7 +174,6 @@ public function update(Request $request)
     public function console(Request $request)
     {
         return Admin::content(function (Content $content) use ($request) {
-
             $connection = $request->get('conn', 'default');
 
             $manager = $this->manager();
@@ -197,7 +197,7 @@ public function console(Request $request)
     }
 
     /**
-     * Execute a redis command
+     * Execute a redis command.
      *
      * @param Request $request
      *
@@ -224,6 +224,7 @@ public function execute(Request $request)
      * Render exception.
      *
      * @param \Exception $exception
+     *
      * @return string
      */
     protected function renderException(\Exception $exception)
@@ -265,4 +266,4 @@ protected function manager()
 
         return RedisManager::instance($conn);
     }
-}
+}