fix: pagination generics

laravel · Feb 13, 2025 · 77f66ed · 77f66ed
1 parent f21afbc
commit 77f66ed
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/Illuminate/Pagination/AbstractCursorPaginator.php b/src/Illuminate/Pagination/AbstractCursorPaginator.php
@@ -568,7 +568,7 @@ public function count(): int
     /**
      * Get the paginator's underlying collection.
      *
-     * @return \Illuminate\Support\Collection
+     * @return \Illuminate\Support\Collection<TKey, TValue>
      */
     public function getCollection()
     {
@@ -578,8 +578,13 @@ public function getCollection()
     /**
      * Set the paginator's underlying collection.
      *
-     * @param  \Illuminate\Support\Collection  $collection
+     * @template TSetKey of array-key
+     * @template TSetValue
+     *
+     * @param  \Illuminate\Support\Collection<TSetKey, TSetValue>  $collection
      * @return $this
+     *
+     * @phpstan-this-out static<TSetKey, TSetValue>
      */
     public function setCollection(Collection $collection)
     {
@@ -613,7 +618,7 @@ public function offsetExists($key): bool
      * Get the item at the given offset.
      *
      * @param  TKey  $key
-     * @return TValue
+     * @return TValue|null
      */
     public function offsetGet($key): mixed
     {

diff --git a/src/Illuminate/Pagination/AbstractPaginator.php b/src/Illuminate/Pagination/AbstractPaginator.php
@@ -738,7 +738,7 @@ public function offsetExists($key): bool
      * Get the item at the given offset.
      *
      * @param  TKey  $key
-     * @return TValue
+     * @return TValue|null
      */
     public function offsetGet($key): mixed
     {

diff --git a/src/Illuminate/Pagination/Cursor.php b/src/Illuminate/Pagination/Cursor.php
@@ -6,6 +6,7 @@
 use Illuminate\Support\Collection;
 use UnexpectedValueException;
 
+/** @implements Arrayable<array-key, mixed> */
 class Cursor implements Arrayable
 {
     /**