[12.x] Refactor Eloquent Builder: Add new addWhereRelationCallback
method to reduce code duplication
#55300
+35
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new internal method called
addWhereRelationCallback
, designed to remove duplicated logic found across several relationship-based query methods in Eloquent.Previously, the following methods contained nearly identical closure logic to apply conditions on related models:
withWhereRelation
whereRelation
orWhereRelation
whereDoesntHaveRelation
orWhereDoesntHaveRelation
Each of these methods used an inline closure to check if the $column parameter was a Closure or a column name, then applied the condition accordingly.
By introducing addWhereRelationCallback, we now reuse a single method that handles this logic, resulting in:
No behavior has been changed—this is a pure refactor aimed at improving code quality.