Fix Inertia SSR errors #53
Conversation
|
Using SSR will also cause a flash of light theme for users who have previously selected a dark theme because the theme is saved in localstorage. I would love to see persisting theme in session or some other way, so we can inject the theme class in app blade during SSR and not have to wait for javascript to change it. |
|
Yeah, cookies can also work and I've gotten by using that route as well. Not sure if it necessarily falls on the responsibility of the starter kit though, as it's fairly easy to setup in user land if that's desired in the scaffolded app. |
|
For those stumbling upon this wondering about the dark mode flash, I have a branch demoing how to prevent it using this starter kit based on the changes from this PR. TL;DR, use a cookie to keep the dark mode state. |
| // For SSR, we can't access the window location, so can only render the layout on the client | ||
| if (typeof window === 'undefined') { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
There is url in usePage hooks, why not just use that?
There was a problem hiding this comment.
We certainly could, both will accomplish the same thing I'm pretty sure. This is just a preference of being explicit about rendering on the server.
There was a problem hiding this comment.
I guess in that context I prefer that way too, thanks for the answer.
JoeyMckenzie
force-pushed
the
fix/inertia-ssr-errors
branch
from
90fcf59 to
011ee04
Compare
There were a handful of errors when running SSR with Inertia, primarily around accessing the
windowand missing some middleware that's required for SSR contexts. This PR resolves those issues. I haven't checked the Vue starter kit yet, though Is suspect that same thing is probably happening there as well.