-
-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for returning Inline in transformers (Issue #763) #765
Open
erezsh
wants to merge
2
commits into
master
Choose a base branch
from
inline
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,9 +15,16 @@ class Discard(Exception): | |
""" | ||
pass | ||
|
||
# Transformers | ||
class Inline(object): | ||
"""When returning an Inline instance in a transformer callback, | ||
the node is inlined, and replaced by its children. | ||
""" | ||
def __init__(self, *items): | ||
self.items = items | ||
|
||
|
||
# Transformers | ||
|
||
class _Decoratable: | ||
"Provides support for decorating methods with @v_args" | ||
|
||
|
@@ -113,11 +120,16 @@ def _transform_children(self, children): | |
for c in children: | ||
try: | ||
if isinstance(c, Tree): | ||
yield self._transform_tree(c) | ||
res = self._transform_tree(c) | ||
elif self.__visit_tokens__ and isinstance(c, Token): | ||
yield self._call_userfunc_token(c) | ||
res = self._call_userfunc_token(c) | ||
else: | ||
res = c | ||
if type(res) is Inline: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bad style: |
||
for i in res.items: | ||
yield i | ||
else: | ||
yield c | ||
yield res | ||
except Discard: | ||
pass | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
|
||
from lark.tree import Tree | ||
from lark.lexer import Token | ||
from lark.visitors import Visitor, Visitor_Recursive, Transformer, Interpreter, visit_children_decor, v_args, Discard | ||
from lark.visitors import Visitor, Visitor_Recursive, Transformer, Interpreter, visit_children_decor, v_args, Discard, Inline | ||
|
||
|
||
class TestTrees(TestCase): | ||
|
@@ -233,6 +233,24 @@ def b(cls, args): | |
x = MyTransformer().transform( t ) | ||
self.assertEqual(x, t2) | ||
|
||
def test_inline(self): | ||
class MyTransformer(Transformer): | ||
def b(self, children): | ||
return 'b' | ||
|
||
def a(self, children): | ||
return Inline('c', 'd') | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a test to test for a Token would be nice just in case we somehow break that in the future. |
||
t = Tree('root', [ | ||
Tree('b', []), | ||
Tree('a', []), | ||
Tree('b', []), | ||
]) | ||
t2 = Tree('root', ['b', 'c', 'd', 'b']) | ||
|
||
x = MyTransformer().transform( t ) | ||
self.assertEqual(x, t2) | ||
|
||
|
||
if __name__ == '__main__': | ||
unittest.main() |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Will this make sure that it is added to the docs?
Anyway, an example would be nice, as well as pointing out to use it
Inline(a, b, c)
and notInline((a,b,c))
.And it should be added to the stubs.