correct the COB to be in the middle of a pixel #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibaudteil
force-pushed
the
feature/1308-cob-fix
branch
from
4fdfed4 to
0d085b9
Compare
We were using the top left corner of the pixel before leading to biases in the filter.
thibaudteil
force-pushed
the
feature/1308-cob-fix
branch
from
0d085b9 to
62765bf
Compare
patkenneally
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using the top left corner of the pixel before leading to biases in the filter.
Description
Fix the COB centering
Verification
None
Documentation
None
Future work
None