Add optional url to de430.bsp download #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patkenneally
force-pushed
the
feature/spice-download-optional
branch
from
5eeee96 to
93a24c1
Compare
thibaudteil
approved these changes
Jan 22, 2025
patkenneally
force-pushed
the
feature/spice-download-optional
branch
from
93a24c1 to
5a4f118
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A user setting is added to the cmake which allows setting the url from which to download the de430.bsp dependency.
Verification
The download was tested with passing a different URL and passing no URL (the default being used)
Documentation
Not updated because conan is being removed. Documentation will be changed.
Future work
None