Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ltxcmds dependency #312

Merged
merged 6 commits into from
Nov 26, 2023
Merged

remove ltxcmds dependency #312

merged 6 commits into from
Nov 26, 2023

Conversation

davidcarlisle
Copy link
Member

This PR removes the dependency on the ltxcmds pakage.

Mostly ltxcmds provides LaTeX commands for other formats so is not needed in hyperref. (Just use \@firstoftwo rather than \ltx@firstoftwo etc)

It does provide a few extra features, here taken from expl3, and given Hy@ names

\let\Hy@LocalAppendToMacro\tl_put_right:Nn
\let\Hy@GlobalAppendToMacro\tl_gput_right:Nn
\let\Hy@ifempty\tl_if_empty:nTF

Also a couple of afterfi commands defined directly in the Hy@ prefix

\long\def\Hy@ReturnAfterFi#1\fi{\fi#1}
\long\def\Hy@ReturnAfterElseFi#1\else#2\fi{\fi#1}

The main advantage is an iterative step towards aligning the hyperref coding with the main kernel sources.

@u-fischer
Copy link
Member

Looks good. The generic hyperref driver in the pdfresources contains some ltxcmds too (I removed them now), so that should be updated first.

@u-fischer u-fischer merged commit 396ba2b into main Nov 26, 2023
1 check passed
muzimuzhi added a commit to muzimuzhi/hyperref that referenced this pull request Nov 27, 2023
Dependencies
- `etexcmds` was removed in
  549ee5d (Merge pull request latex3#276 from muzimuzhi/drop-etexcmds, 2023-02-19)
- `infwarerr` was removed in
  908e303 (remove infwarerr (latex3#317), 2023-11-26)
- `ltxcmds` and `pdftexcmds` were removed in
  396ba2b (remove ltxcmds dependency (latex3#312), 2023-11-26)
@u-fischer u-fischer deleted the noltxcmds branch October 17, 2024 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants