Feature/mrhs misc #1515
Open
Feature/mrhs misc #1515
+355
−220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocation overheads when memory pool is disabled
This reverts commit 8f72560.
…imization can optimize out infinities rendering the use of heterogenous atomics with an inifinity sentinal. As an alternative we can use negative zero as the sentinal. Default remains infinity, disable with QUDA_HETEROGENEOUS_ATOMIC_INF_INIT=OFF
…nvc++ allowing for the removal of the WARs deployed previously
…PrintMatrix routine. Apply same patch to genericPrintVector for future proofing
hummingtree
reviewed
Nov 27, 2024
| @@ -104,13 +103,18 @@ namespace quda | |||
| if (doHalo<kernel_type>(d) && ghost) { | |||
| const int ghost_idx = ghostFaceIndexStaggered<1>(coord, arg.dim, d, 1); | |||
| const Link U = arg.improved ? arg.U(d, coord.x_cb, parity) : arg.U(d, coord.x_cb, parity, StaggeredPhase(coord, d, +1, arg)); | |||
| Vector in = arg.halo.Ghost(d, 1, ghost_idx + src_idx * arg.nFace * arg.dc.ghostFaceCB[d], their_spinor_parity); | |||
| out = mv_add(U, in, out); | |||
| for (auto s = 0; s < n_src_tile; s++) { | |||
There was a problem hiding this comment.
Should #pragma unroll be added here? Although I would assume the compiler does this by itself already.
There was a problem hiding this comment.
Probably a good idea. I'll add that on next push.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a bit of a catch all
QUDA_MAX_MULTI_RHS_TILE, with the default left at size 1 for now.FieldTmpnow supports creating temporaries using parameters as opposed another field instanceQUDA_HETEROGENEOUS_ATOMIC_INF_INIT=OFF). Not a problem by default, but is with latest clang with-Ofast.printGenericMatrix