feat: Use callbacks for evaluation hotpath. (#234)

launchdarkly · Aug 21, 2023 · 27e5454 · 27e5454
1 parent cf01b14
commit 27e5454
Show file tree

Hide file tree

Showing 5 changed files with 595 additions and 398 deletions.
diff --git a/packages/shared/sdk-server/__tests__/evaluation/Evaluator.segments.test.ts b/packages/shared/sdk-server/__tests__/evaluation/Evaluator.segments.test.ts
@@ -34,12 +34,14 @@ class TestQueries implements Queries {
     },
   ) {}
 
-  async getFlag(key: string): Promise<Flag | undefined> {
-    return this.data.flags?.find((flag) => flag.key === key);
+  getFlag(key: string, cb: (flag: Flag | undefined) => void): void {
+    const res = this.data.flags?.find((flag) => flag.key === key);
+    cb(res);
   }
 
-  async getSegment(key: string): Promise<Segment | undefined> {
-    return this.data.segments?.find((segment) => segment.key === key);
+  getSegment(key: string, cb: (segment: Segment | undefined) => void): void {
+    const res = this.data.segments?.find((segment) => segment.key === key);
+    cb(res);
   }
 
   getBigSegmentsMembership(