Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optimize segment lookup for large segments. #235

Merged
merged 38 commits into from
Aug 21, 2023

Conversation

kinyoklion
Copy link
Member

No description provided.

@kinyoklion kinyoklion marked this pull request as ready for review August 18, 2023 22:22
@kinyoklion kinyoklion marked this pull request as draft August 18, 2023 22:23
@kinyoklion kinyoklion marked this pull request as ready for review August 18, 2023 22:25
Copy link
Contributor

@yusinto yusinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we also able to add unit tests please?

packages/shared/sdk-server/src/store/serialization.ts Outdated Show resolved Hide resolved
packages/shared/sdk-server/tsconfig.json Outdated Show resolved Hide resolved
Base automatically changed from rlamb/performance-experimentation to main August 21, 2023 19:57
@kinyoklion kinyoklion merged commit ac575d0 into main Aug 21, 2023
@kinyoklion kinyoklion deleted the rlamb/optimize-large-segments branch August 21, 2023 20:37
@github-actions github-actions bot mentioned this pull request Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants