feat: Refactor variation method and consistency tracking. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
commented
Aug 31, 2023
| @@ -307,7 +307,7 @@ export default class LDClientImpl implements LDClient { | |||
| key: string, | |||
| context: LDContext, | |||
| defaultValue: LDMigrationStage, | |||
| ): Promise<LDMigrationDetail> { | |||
There was a problem hiding this comment.
Renamed this as it isn't "detail" any longer.
kinyoklion
commented
Aug 31, 2023
| const convertedContext = Context.fromLDContext(context); | ||
| const [{ detail }, flag] = await this.evaluateIfPossible( | ||
| key, | ||
| context, | ||
| defaultValue, | ||
| this.eventFactoryWithReasons, | ||
| this.eventFactoryDefault, |
There was a problem hiding this comment.
Should not include reasons by default for the evaluation event associated with the migration. It will be in the migration_op event.
kinyoklion
requested review from
yusinto and
louis-launchdarkly
as code owners
louis-launchdarkly
approved these changes
Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was reviewing my code and Mathew's and noticed some inconsistencies in how we approach the consistency check. Node correctly only did the check when sampled, but exposed more information than we want. So we have changed the two SDKs to be consistent with each other. So go now only samples when we want, and node will expose less information,