feat: add option to define terminationGracePeriodSeconds #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
approved these changes
Mar 19, 2024
keelerm84
pushed a commit
that referenced
this pull request
Mar 19, 2024
🤖 I have created a release *beep* *boop* --- ## [3.3.0](3.2.0...3.3.0) (2024-03-19) ### Features * Add option to define terminationGracePeriodSeconds ([#60](#60)) ([f65b60b](f65b60b)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Thank you for your contribution! This has been released in 3.3.0. Have a great week! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Related issues
Related issue, setting terminationGracePeriodSeconds is needed when combined with long sleep in preStopHooks
#56
Describe the solution you've provided
Simple addition to enable defining terminationGracePeriodSeconds for ld-relay
Describe alternatives you've considered
No alternatives considered
Additional context
Add any other context about the pull request here.