Add test for forbidden response (#27)

cmd/root.go

@@ -30,9 +30,9 @@ func Execute() {
 	err := rootCmd.Execute()
 	if err != nil {
 		switch {
-		case errors.Is(err, errs.ErrInvalidBaseURI):
-			fmt.Fprintln(os.Stderr, err.Error())
-		case errors.Is(err, errs.ErrUnauthorized):
+		case errors.Is(err, errs.ErrForbidden),
+			errors.Is(err, errs.ErrInvalidBaseURI),
+			errors.Is(err, errs.ErrUnauthorized):
 			fmt.Fprintln(os.Stderr, err.Error())
 		default:
 			fmt.Println(rootCmd.ErrPrefix(), err.Error())

internal/errors/errors.go

@@ -3,6 +3,7 @@ package errors
 import "errors"
 
 var (
+	ErrForbidden      = errors.New("You do not have permission to make this request")
 	ErrInvalidBaseURI = errors.New("baseUri is invalid")
-	ErrUnauthorized   = errors.New("You are not authorized to make this request.")
+	ErrUnauthorized   = errors.New("You are not authorized to make this request")
 )

internal/projects/projects.go

@@ -43,11 +43,14 @@ func (c ProjectsClient) List(ctx context.Context) (*ldapi.Projects, error) {
 func ListProjects(ctx context.Context, client Client) ([]byte, error) {
 	projects, err := client.List(ctx)
 	if err != nil {
-		if err.Error() == "401 Unauthorized" {
+		switch err.Error() {
+		case "401 Unauthorized":
 			return nil, errors.ErrUnauthorized
+		case "403 Forbidden":
+			return nil, errors.ErrForbidden
+		default:
+			return nil, err
 		}
-
-		return nil, err
 	}
 
 	projectsJSON, err := json.Marshal(projects)

internal/projects/projects_test.go

@@ -19,10 +19,14 @@ func strPtr(s string) *string {
 type GetProjectsResponse struct{}
 
 type MockClient struct {
+	hasForbiddenErr    bool
 	hasUnauthorizedErr bool
 }
 
 func (c MockClient) List(ctx context.Context) (*ldapi.Projects, error) {
+	if c.hasForbiddenErr {
+		return nil, errors.New("403 Forbidden")
+	}
 	if c.hasUnauthorizedErr {
 		return nil, errors.New("401 Unauthorized")
 	}
@@ -91,13 +95,23 @@ func TestListProjects(t *testing.T) {
 		assert.JSONEq(t, expected, string(response))
 	})
 
-	t.Run("with invalid accessToken is forbidden", func(t *testing.T) {
+	t.Run("without access is forbidden", func(t *testing.T) {
+		mockClient := MockClient{
+			hasForbiddenErr: true,
+		}
+
+		_, err := projects.ListProjects(context.Background(), mockClient)
+
+		assert.EqualError(t, err, "You do not have permission to make this request")
+	})
+
+	t.Run("with invalid accessToken is unauthorized", func(t *testing.T) {
 		mockClient := MockClient{
 			hasUnauthorizedErr: true,
 		}
 
 		_, err := projects.ListProjects(context.Background(), mockClient)
 
-		assert.EqualError(t, err, "You are not authorized to make this request.")
+		assert.EqualError(t, err, "You are not authorized to make this request")
 	})
 }