feat: Change the typing for the AIConfig #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kinyoklion
reviewed
Nov 15, 2024
ldai/client.py
Outdated
| return self._id | ||
|
|
||
| @property | ||
| def temperature(self): |
There was a problem hiding this comment.
Do these comments need to indicate optionality?
There was a problem hiding this comment.
I added return types to the method signatures. I think that should be sufficient.
kinyoklion
approved these changes
Nov 15, 2024
keelerm84
pushed a commit
that referenced
this pull request
Nov 21, 2024
🤖 I have created a release *beep* *boop* --- ## [0.2.0](0.1.1...0.2.0) (2024-11-21) ### Features * Change the typing for the AIConfig ([#16](#16)) ([daf9537](daf9537)) ### Bug Fixes * Change linting tools to dev-only dependency ([#15](#15)) ([c752739](c752739)) * Verify prompt payload exists before accessing it ([#19](#19)) ([d9dd21f](d9dd21f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit inlines the
AIConfigDataclass into the existingAIConfig.It also introduces a new type,
ModelConfigto replace the much looser dictionary config that was originally in play. This new model contains specific, typed properties for the model id, temperature, and max tokens. Additional model-specific attributes can be accessed as well.