Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix context usage for message interpolation #24

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: Fix context usage for message interpolation #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ldai/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def config(
all_variables = {}
if variables:
all_variables.update(variables)
all_variables['ldctx'] = context
all_variables['ldctx'] = context.to_dict()

messages = None
if 'messages' in variation and isinstance(variation['messages'], list) and all(
Expand Down
41 changes: 38 additions & 3 deletions ldai/testing/test_model_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,19 @@ def td() -> TestData:
.variations(
{
'model': {'id': 'fakeModel', 'parameters': {'extra-attribute': 'I can be anything I set my mind/type to'}},
'messages': [{'role': 'system', 'content': 'Hello, {{ldctx.name}}!'}],
'messages': [{'role': 'system', 'content': 'Hello, {{ldctx.name}}! Is your last name {{ldctx.last}}?'}],
'_ldMeta': {'enabled': True, 'versionKey': 'abcd'},
}
)
.variation_for_all(0)
)

td.update(
td.flag('multi-ctx-interpolation')
.variations(
{
'model': {'id': 'fakeModel', 'parameters': {'extra-attribute': 'I can be anything I set my mind/type to'}},
'messages': [{'role': 'system', 'content': 'Hello, {{ldctx.user.name}}! Do you work for {{ldctx.org.shortname}}?'}],
'_ldMeta': {'enabled': True, 'versionKey': 'abcd'},
}
)
Expand Down Expand Up @@ -192,7 +204,7 @@ def test_provider_config_handling(ldai_client: LDAIClient):


def test_context_interpolation(ldai_client: LDAIClient):
context = Context.builder('user-key').name("Sandy").build()
context = Context.builder('user-key').name("Sandy").set('last', 'Beaches').build()
default_value = AIConfig(enabled=True, model=ModelConfig('fake-model'), messages=[])
variables = {'name': 'World'}

Expand All @@ -202,7 +214,30 @@ def test_context_interpolation(ldai_client: LDAIClient):

assert config.messages is not None
assert len(config.messages) > 0
assert config.messages[0].content == 'Hello, Sandy!'
assert config.messages[0].content == 'Hello, Sandy! Is your last name Beaches?'
assert config.enabled is True

assert config.model is not None
assert config.model.id == 'fakeModel'
assert config.model.get_parameter('temperature') is None
assert config.model.get_parameter('maxTokens') is None
assert config.model.get_parameter('extra-attribute') == 'I can be anything I set my mind/type to'


def test_multi_context_interpolation(ldai_client: LDAIClient):
user_context = Context.builder('user-key').name("Sandy").build()
org_context = Context.builder('org-key').kind('org').name("LaunchDarkly").set('shortname', 'LD').build()
context = Context.multi_builder().add(user_context).add(org_context).build()
default_value = AIConfig(enabled=True, model=ModelConfig('fake-model'), messages=[])
variables = {'name': 'World'}

config, _ = ldai_client.config(
'multi-ctx-interpolation', context, default_value, variables
)

assert config.messages is not None
assert len(config.messages) > 0
assert config.messages[0].content == 'Hello, Sandy! Do you work for LD?'
assert config.enabled is True

assert config.model is not None
Expand Down
Loading