Updates to Python tracking #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keelerm84
reviewed
Oct 15, 2024
|
|
||
| class LDAIClient: | ||
| """The LaunchDarkly AI SDK client object.""" | ||
|
|
||
| def __init__(self, client: LDClient): | ||
| self.client = client | ||
|
|
||
| def model_config(self, key: str, context: Context, default_value: str, variables: Optional[Dict[str, Any]] = None) -> Any: | ||
| def model_config(self, key: str, context: Context, default_value: str, variables: Optional[Dict[str, Any]] = None) -> AIConfig: |
There was a problem hiding this comment.
It looks like this is returning a dictionary, not an AIConfig type.
Also just noticed there is a rogue print in there.
There was a problem hiding this comment.
@keelerm84 updated the logic to return an AIConfig
Remove tracking utils return AI Config Remove errant print
keelerm84
approved these changes
Oct 18, 2024
| from typing import Callable, TypedDict | ||
| from dataclasses import dataclass | ||
|
|
||
| @dataclass |
There was a problem hiding this comment.
I don't typically see both @dataclass and TypedDict used together. Are both of these needed? If so, why not on the other types below?
There was a problem hiding this comment.
@keelerm84 this is a lack of knowledge on my part. I switched them over to dataclasses in the following commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
variationDetailwhich generates an event each time tovariation.