chore: fix secret passing in release workflows #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #233949: Swap sdk-test-harness to Github Actions. |
kinyoklion
reviewed
Feb 21, 2024
.github/workflows/manual-release.yml
Outdated
| tag: ${{ inputs.tag }} | ||
| secrets: | ||
| token: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Because it is a workflow, instead of a composite, you shouldn't need to pass. The workflow can have its own permissions.
There was a problem hiding this comment.
There was a problem hiding this comment.
When a reusable workflow is triggered by a caller workflow, the github context is always associated with the caller workflow. The called workflow is automatically granted access to github.token and secrets.GITHUB_TOKEN. For more information about the github context, see "[Contexts](https://docs.github.com/en/actions/learn-github-actions/contexts#github-context)."
There was a problem hiding this comment.
Workflows have a greater trust level than a composite, as they aren't really meant to come from external sources like a composite.
There was a problem hiding this comment.
Yea, I see that secrets is automatically available. This does work though, but I'll refactor to remove it.
kinyoklion
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't realize that reusable workflows need a special syntax for passing secrets like
GITHUB_TOKEN, different thaninputs.The existing config results in an invalid workflow file (although it works fine in
act.)