feat: Add hooks contract tests. #200
Conversation
kinyoklion
force-pushed
the
rlamb/add-hooks-contract-tests
branch
from
ddfde24
to
9211849
Compare
|
Curious why the change to the non-blocking push? I'm guessing it was forcing the SDK to be synchronized with whatever test code expectations had (or had not) been written? |
Co-authored-by: Casey Waldren <[email protected]>
The node SDK doesn't have a way to do a synchronous http request. So it fires and forgets the request and the tests passed. Because the evaluation continues. |
Co-authored-by: Casey Waldren <[email protected]>
Co-authored-by: Casey Waldren <[email protected]>
…kly/sdk-test-harness into rlamb/add-hooks-contract-tests
|
TODO: change 0xDEADBEEF to something that fits into a signed int Edit: TODONE. |
|
Alright, .NET server is now passing all contract tests. |
🤖 I have created a release *beep* *boop* --- ## [2.9.0](v2.8.3...v2.9.0) (2024-03-22) ### Features * Add hooks contract tests. ([#200](#200)) ([53331bb](53331bb)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This PR adds support for basic contract testing of hooks.
It does not include support for dynamic registration of hooks.
It does not yet test hook execution order.
It does not test hooks throwing errors.