Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Accessibility: Describe the notebook dropdown for accessibility tools #11430

Conversation

personalizedrefrigerator
Copy link
Collaborator

@personalizedrefrigerator personalizedrefrigerator commented Nov 21, 2024

Summary

This pull request adds an accessibilityHint to the "move to notebook" dropdown.

Before/after comparison (Android 13/TalkBack):

  • Before: Before this pull request, TalkBack might read Notebook title, button, Opens dropdown (for some "Notebook title").
  • After: With this pull request, TalkBack reads Notebook title, button, Selects a notebook Opens dropdown (for some "Notebook title").

Related to #10795.

Note

Currently, <Dropdown> doesn't add punctuation when concatenating hint text. It may make sense to change this in a follow-up pull request.

@personalizedrefrigerator personalizedrefrigerator added mobile All mobile platforms accessibility Related to accessibility labels Nov 21, 2024
@personalizedrefrigerator personalizedrefrigerator changed the title Mobile: Accessibility: Describe the notebook dropdown for accessibility Mobile: Accessibility: Describe the notebook dropdown for accessibility tools Nov 21, 2024
@laurent22 laurent22 merged commit 81ec3eb into laurent22:dev Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Related to accessibility mobile All mobile platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants