Upgrade to Swift 5 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update dependencies in order to use Swift 5 Fix objective function errors
Update Alamofire version to 5.0.0-rc.2
|
Hey, welcome to the project and thanks for the contribution!! 🎉 Would it be possible for |
Great suggestion !. I updated my code |
phrohdoh
reviewed
Oct 3, 2019
WWCodeDFW/WWCodeDFW/ApiService.swift
Outdated
| @@ -15,6 +15,8 @@ enum ApiServiceError: Error { | |||
| case failureRequestError | |||
| } | |||
|
|
|||
| typealias ApiResult<T> = Result<T, Error> | |||
There was a problem hiding this comment.
This should be Result<T, ApiServiceError> since all of ApiResult's uses have en error type of ApiServiceError.
|
@laurrenreed Any chance you or someone else could take a look at merging this? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.