Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable length key support and major template refactoring to support key as a template parameter #661

Closed
wants to merge 14 commits into from
Closed

Variable length key support and major template refactoring to support key as a template parameter #661

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
d8a047f
WIP for variable length keys and templating the Key as a type argument
laurynas-biveinis Jan 28, 2025
9f83b1b
Only permits instantiation where Key = std::uint64_t.
Jan 28, 2025
81d3d42
Addressing some compiler complaints (MSC) about encode/decode
Jan 28, 2025
11c4f56
Resolving more CI complaints.
Jan 28, 2025
d72dc98
Some fixes from @laurynas-biveinis
Jan 29, 2025
e1b0e3c
Moves dump() methods into headers per CI complaint.
Jan 29, 2025
f6ff145
Disables OOM tests with FIXME
Jan 29, 2025
98ee116
clang-tidy header import cleanup.
Jan 29, 2025
ed6ef07
Removes test_art_key as not required.
Jan 29, 2025
b4bf79f
Fixes
laurynas-biveinis Jan 30, 2025
4155d46
clang-format fix
laurynas-biveinis Jan 30, 2025
94e67d2
Further fuzzer fixes
laurynas-biveinis Jan 30, 2025
e9c3776
Remove incorrect gnu::pure attributes from mutex_db too
laurynas-biveinis Jan 30, 2025
18cd288
Remove a cppcheck suppression
laurynas-biveinis Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@
**/*~
**/*#*

cf_off.sh
cf_on.sh
cf_now.sh
ct_off.sh
ct_on.sh
run-cmake.sh
loop-test.sh
compile1.sh
thompsonbry marked this conversation as resolved.
Show resolved Hide resolved
/docs/
10 changes: 6 additions & 4 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ set(GCC_CXX_WARNING_FLAGS
"-Wduplicated-cond" "-Wextra-semi" "-Wfloat-equal" "-Wformat-overflow=2"
"-Wformat-signedness" "-Wformat-truncation=2" "-Wformat=2"
"-Wimplicit-fallthrough=5" "-Winvalid-pch" "-Wlogical-op" "-Wmismatched-tags"
"-Wmissing-declarations" "-Wmissing-include-dirs" "-Wnoexcept"
laurynas-biveinis marked this conversation as resolved.
Show resolved Hide resolved
"-Wmissing-include-dirs" "-Wnoexcept"
"-Wnon-virtual-dtor" "-Wnull-dereference" "-Wold-style-cast"
"-Woverloaded-virtual" "-Wpacked" "-Wplacement-new=2" "-Wredundant-decls"
"-Wshadow=global" "-Wsign-conversion" "-Wsign-promo" "-Wstrict-null-sentinel"
Expand Down Expand Up @@ -536,6 +536,8 @@ set(CPPCHECK_ARGS
# False positives on structured bindings with 2.5
"--suppress=unassignedVariable"
"--suppress=unusedVariable"
# TODO(laurynas): figure out and fix
"--suppress=throwInNoexceptFunction"
coderabbitai[bot] marked this conversation as resolved.
Show resolved Hide resolved
laurynas-biveinis marked this conversation as resolved.
Show resolved Hide resolved
# Informational message that fails the build. Remove once cppcheck 2.11 is the
# minimum
"--suppress=normalCheckLevelMaxBranches")
Expand Down Expand Up @@ -702,9 +704,9 @@ if(LIBFUZZER_AVAILABLE)
target_link_libraries(unodb_qsbr_lf PUBLIC unodb_util Threads::Threads)
endif()

add_unodb_library(unodb art.cpp art.hpp art_common.cpp art_common.hpp
mutex_art.hpp optimistic_lock.hpp art_internal_impl.hpp olc_art.hpp
olc_art.cpp art_internal.cpp art_internal.hpp node_type.hpp)
add_unodb_library(unodb art.cpp art.hpp art_common.hpp
mutex_art.hpp mutex_art.cpp optimistic_lock.hpp art_internal_impl.hpp
olc_art.hpp olc_art.cpp art_internal.cpp art_internal.hpp node_type.hpp)
target_link_libraries(unodb PUBLIC unodb_util unodb_qsbr)
if(LIBFUZZER_AVAILABLE)
target_link_libraries(unodb_lf PUBLIC unodb_util unodb_qsbr_lf)
Expand Down
Loading
Loading