Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change it to be compatible with Twitter Bootstrap #7

Merged
merged 3 commits into from
Sep 2, 2014

Conversation

xavadu
Copy link
Contributor

@xavadu xavadu commented Sep 1, 2014

I change the code to instead of specify device, specify a Twitter Bootstrap Media Query
http://getbootstrap.com/css/#grid

It is better approach by diferent points:

  • Isn't necessary match about isSmartDevice().. (a list that need maintenance and not cover all the devices),
  • Also work for a window resize (not necessarily a device)

TODO:

lavinjj added a commit that referenced this pull request Sep 2, 2014
Change it to be compatible with Twitter Bootstrap
@lavinjj lavinjj merged commit 91d6fa8 into lavinjj:master Sep 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants