Merge pull request #2180 from laws-africa/core-docs

prevent creation of core documents in admin, and better errors if one…

peachjam/admin.py

@@ -179,6 +179,9 @@ class PeachJamSettingsAdmin(admin.ModelAdmin):
         "document_jurisdictions",
     )
 
+    def has_add_permission(self, request):
+        return False
+
     def changelist_view(self, request, extra_context=None):
         # redirect to edit the singleton
         return redirect("admin:peachjam_peachjamsettings_change", pj_settings().pk)
@@ -844,7 +847,9 @@ def fixup(item):
 
 @admin.register(CoreDocument)
 class CoreDocumentAdmin(DocumentAdmin):
-    pass
+    def has_add_permission(self, request):
+        # this is prevented because there is no view that handles a CoreDocument
+        return False
 
 
 @admin.register(GenericDocument)

peachjam/views/documents.py

@@ -64,6 +64,10 @@ def dispatch(self, request, *args, **kwargs):
 
             return view.dispatch(request, *args, **kwargs)
 
+        raise Exception(
+            f"The document type {obj.doc_type} does not have a view registered."
+        )
+
 
 @method_decorator(add_slash_to_frbr_uri(), name="setup")
 class DocumentSourceView(DetailView):