-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 'YOU ARE HERE' indicator in Kanvas, cloud documentation #458
base: master
Are you sure you want to change the base?
Fix 'YOU ARE HERE' indicator in Kanvas, cloud documentation #458
Conversation
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@ShivprasadRoul adding it as an agenda item to the meeting minutes. |
|
||
**Layer5 Cloud** ([docs](/cloud)) is an identity provider and global console for Meshery deployments with an extensible and highly flexible authorization framework, tenant entitlement services, service provider-grade organizational hierarchy, team workspace management and a content catalog for public and private hosting of cloud native architectures. Layer5 Cloud is available as a service or self-hosted. | ||
</div> | ||
<div style="display:flex;flex-direction:column;margin-bottom:2rem;margin-top:1rem;padding:1rem;box-shadow:inset 0 0 4em #ebc01766,0 0 0 2px #ebc01766,.3em .3em 1em #ebc01733;position:relative;"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make all these repeated CSS, reusable.
Thanks for working on this, @ShivprasadRoul! |
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
one-time instructions here - https://github.com/layer5io/docs/pull/458/checks?check_run_id=38840866547 - for amending commits, @ShivprasadRoul |
[Docs] Fix "YOU ARE HERE" indicator in Kanvas documentation
Description
This PR fixes the "YOU ARE HERE" indicator in the Kanvas documentation page. The indicator was previously not rendering correctly and showing raw HTML code. Now it's properly implemented with the same styling as in the Cloud documentation, with capitalized "YOU ARE HERE" text as requested.
During the discussion about this issue, I was initially asked to replace the square with a pin icon, but after trying this approach, I found that it looked odd and negatively affected the layout. Instead, I implemented a solution that highlights the entire section with the same styling used in the Cloud documentation, which provides better visual indication and consistency across the docs.
As per Lee's feedback, I've made sure to capitalize the "YOU ARE HERE" text to maintain consistency with the Cloud documentation.
Before:


After:


Notes for Reviewers
This PR fixes #455
Signed commits