Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[components] feat: Setup ThemeProvider (WIP) #115

Closed

Conversation

nebula-aac
Copy link
Contributor

Notes for Reviewers

This PR is related to #17

This is a work in progress.

Signed commits

  • Yes, I signed my commits.

@nebula-aac nebula-aac changed the title [components] feat: Setup ThemeProvider [components] feat: Setup ThemeProvider (WIP) Sep 28, 2023
packages/components/src/theme/defaultTheme.ts Outdated Show resolved Hide resolved
@@ -0,0 +1,87 @@
import { SistentThemeBase } from './types/SistentTheme';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cloud's theme is an ideal theme to source from.

Signed-off-by: Antonette Caldwell <[email protected]>
nebula-aac and others added 3 commits September 28, 2023 19:19
Co-authored-by: Lee Calcote <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
Signed-off-by: Antonette Caldwell <[email protected]>
t.literal('lime'),
t.literal('yellow'),
t.literal('orange'),
t.literal('teal'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know. As I said, I need to move some of this to another place, and revert the changes. I wanted to get a PR up to show that I'm working on something

@nebula-aac nebula-aac self-assigned this Oct 6, 2023
@nebula-aac nebula-aac added pr/do-not-merge PRs not ready to be merged priority/high High priority issue labels Oct 6, 2023
@nebula-aac
Copy link
Contributor Author

Closing in favor of #434

@nebula-aac nebula-aac closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/components pr/do-not-merge PRs not ready to be merged priority/high High priority issue
Development

Successfully merging this pull request may close these issues.

2 participants