Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): refactor components #221

Merged
merged 8 commits into from
Nov 7, 2023
Merged

fix(components): refactor components #221

merged 8 commits into from
Nov 7, 2023

Conversation

nebula-aac
Copy link
Contributor

@nebula-aac nebula-aac commented Nov 3, 2023 •
edited
Loading

Notes for Reviewers

This PR fixes #218

Major Changes

  • Publish beta tag for testing
  • Renamed all index.ts to index.tsx
  • Convert from Vite to tsup (issues with externalizing React JSX runtime)
  • Attach JSX.Element to every React components to return the element
  • Fixed typo on CustomColumnVisibilityControl
  • Added react-error-boundary to tsconfig.json
  • Import and export explicitly the custom data tables
  • Import and export mui-datatables as DataTable, which means using the child of DataTable for the time being
  • Updated package.json exports fields and main entry
  • Removed react-error-boundary for now as this is the cause of the React JSX runtime issue.
  • UPDATED Commented out react-error-boundary type declaration file for now
  • UDPATED Redid const to function as React.FC will no longer exist in a certain version of @types/react
  • UPDATED Added custom data table

Signed commits

  • Yes, I signed my commits.

@nebula-aac
fix(components): refactor components
5b90831 
Signed-off-by: Antonette Caldwell <[email protected]>
@nebula-aac nebula-aac added the pr/do-not-merge PRs not ready to be merged label Nov 3, 2023
@nebula-aac nebula-aac merged commit c479704 into master Nov 7, 2023
5 checks passed
@nebula-aac nebula-aac deleted the feat/218-components-tsup branch November 7, 2023 18:21
@nebula-aac nebula-aac linked an issue Nov 7, 2023 that may be closed by this pull request
[components] Fix Grid export #217
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component/components component/icons pr/do-not-merge PRs not ready to be merged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[components] convert to tsup [components] Fix Grid export
1 participant
@nebula-aac