Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix svg path in toolbar used icons #275

Closed
wants to merge 1 commit into from

Conversation

sudhanshutech
Copy link
Member

Notes for Reviewers

This PR fixes #

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Sudhanshu Dasgupta <[email protected]>
Copy link
Contributor

@nebula-aac nebula-aac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I revert these because we need to rely on the official packages, not the relative path.

Even though this is in a monorepo, we will need to treat this as a separate package that depends on another package.

I'm not getting this problem on my end.

@sudhanshutech
Copy link
Member Author

Oh okay, in that sense. Could be any other issue then

@nebula-aac
Copy link
Contributor

I'm not sure, because when I tested your PR last night, I noticed the svg package wasn't showing up for you. So I'm not sure what type of setup you have on your end.

Can you provide some details on your workflow?

@sudhanshutech
Copy link
Member Author

workflow in the sense?

@sudhanshutech sudhanshutech added the pr/do-not-merge PRs not ready to be merged label Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/components pr/do-not-merge PRs not ready to be merged
Development

Successfully merging this pull request may close these issues.

2 participants