fix: updated docs #759
fix: updated docs #759
Conversation
Signed-off-by: ian whitney <[email protected]>
| @@ -67,7 +67,8 @@ build: | |||
|
|
|||
| ``` | |||
| attach sistent to your project: | |||
| npm install [path to sistent repo ] | |||
| npm pack (in sistent repo) | |||
| npm install /path/to/file.tgz (in another repo) | |||
There was a problem hiding this comment.
why you changing this path to specific ?
There was a problem hiding this comment.
i wasnt able to get sistent to attach when running meshery with the given commands in the readme. I had to pack in a tgz file and then ask npm to install that. This was the only way it was able to attach. If the orginial works for you maybe i can add this as an alternative here? Let me know your thoughts. thanks for your time to comment.
There was a problem hiding this comment.
@nebula-aac, what do you think?
There was a problem hiding this comment.
@SAHU-01 you might have a perspective to offer.
There was a problem hiding this comment.
@ianrwhitney if you wish to attach sistent with meshery, when you go into the ui folder of meshery and do a npm i [sistent path] it adds the sistent changes . If you attempt to attach sistent by executing npm i [sistent path] directly in meshery remote repo, it most likely doesn't work (at least in my case).
For the other repositories that I've added sistent code to, the npm i [sistent path] works well without an issue. So I believe @leecalcote we should keep the original one and maybe add a special case for meshery repo below, to either run it inside ui or to use a specific path like your suggestion @ianrwhitney.
There was a problem hiding this comment.
yea i can add this as an alternative. thanks for the comments
There was a problem hiding this comment.
It is okay as an alternative, but to prevent further confusion, it is better to raise the issue of what happens when you attempts to use npm install [sistent path] and we can help to do a work around. I haven't ran into this issue, and would like to investigate this if there is a step that may be missing.
Signed-off-by: ianwhitney <[email protected]>
Notes for Reviewers
This PR fixes #
This PR helps clarify how to attach and run sistent repo in another project.
Signed commits