Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error boundary #779

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Improve error boundary #779

merged 2 commits into from
Nov 4, 2024

Conversation

sudhanshutech
Copy link
Member

@sudhanshutech sudhanshutech commented Oct 29, 2024 •
edited
Loading

Notes for Reviewers

This PR fixes #777

Signed commits

  • Yes, I signed my commits.

@sudhanshutech
fix(error): boundary
98b56ac 
Signed-off-by: Sudhanshu Dasgupta <[email protected]>
leecalcote
leecalcote reviewed Oct 31, 2024
View reviewed changes
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting this additional information into the Feedback form is ideal, so that maintainers can be empowered with these details.

src/custom/ErrorBoundary/ErrorBoundary.tsx Outdated Show resolved Hide resolved
@sudhanshutech sudhanshutech merged commit c34b3da into layer5io:master Nov 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leecalcote leecalcote leecalcote left review comments

@amitamrutiya amitamrutiya amitamrutiya approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Improve sistent error boundary
3 participants
@sudhanshutech @leecalcote @amitamrutiya