Silence a few more warnings

lballabio · Aug 19, 2024 · ff8fa36 · ff8fa36
1 parent 5072f0e
commit ff8fa36
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/.clang-tidy b/.clang-tidy
@@ -25,6 +25,7 @@ Checks: >
           -cppcoreguidelines-avoid-magic-numbers,
           -cppcoreguidelines-avoid-non-const-global-variables,
           -cppcoreguidelines-init-variables,
+          -cppcoreguidelines-macro-to-enum,
           -cppcoreguidelines-macro-usage,
           -cppcoreguidelines-narrowing-conversions,
           -cppcoreguidelines-non-private-member-variables-in-classes,

diff --git a/ql/cashflow.cpp b/ql/cashflow.cpp
@@ -42,8 +42,8 @@ namespace QuantLib {
             // specified in the settings (if any)
             ext::optional<bool> includeToday =
                 Settings::instance().includeTodaysCashFlows();
-            if (includeToday) // NOLINT(readability-implicit-bool-conversion)
-                includeRefDate = *includeToday;
+            if (includeToday.has_value())
+                includeRefDate = includeToday;
         }
         return Event::hasOccurred(refDate, includeRefDate);
     }

diff --git a/ql/experimental/callablebonds/treecallablebondengine.cpp b/ql/experimental/callablebonds/treecallablebondengine.cpp
@@ -44,7 +44,7 @@ namespace QuantLib {
     }
 
     void TreeCallableFixedRateBondEngine::calculate() const {
-        return calculateWithSpread(arguments_.spread);
+        calculateWithSpread(arguments_.spread);
     }
 
     void TreeCallableFixedRateBondEngine::calculateWithSpread(Spread s) const {

diff --git a/ql/math/matrixutilities/tqreigendecomposition.cpp b/ql/math/matrixutilities/tqreigendecomposition.cpp
@@ -48,7 +48,7 @@ namespace QuantLib {
         for (Size k=n-1; k >=1; --k) {
             while (!offDiagIsZero(k, e)) {
                 Size l = k;
-                while (--l > 0 && !offDiagIsZero(l,e));
+                while (--l > 0 && !offDiagIsZero(l,e)); // NOLINT(bugprone-inc-dec-in-conditions)
                 iter_++;
 
                 Real q = d_[l];

diff --git a/ql/version.hpp b/ql/version.hpp
@@ -34,7 +34,6 @@
 #define QL_VERSION "1.36-dev"
 
 //! version hexadecimal number
-// NOLINTNEXTLINE(cppcoreguidelines-macro-to-enum)
 #define QL_HEX_VERSION 0x01360000
 
 /*! @}  */