Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Examples #1760

Merged
merged 2 commits into from
Aug 7, 2023
Merged

Modernize Examples #1760

merged 2 commits into from
Aug 7, 2023

Conversation

sweemer
Copy link
Contributor

@sweemer sweemer commented Aug 5, 2023

As discussed in #1758 (comment), here is a first pass at modernizing the examples by introducing auto and ext::make_shared. I also removed spaces between angle brackets for a more modern feel.

I tried to preserve the existing formatting as much as possible, but feel free to reformat the changed lines if you prefer.

We can add auto in a lot more places, both in the examples and the main library, just let me know if you think now is the time.

@coveralls
Copy link

coveralls commented Aug 5, 2023

Coverage Status

coverage: 71.903%. remained the same when pulling 6f64993 on sweemer:modernize-examples into aff1e87 on lballabio:master.

@lballabio lballabio added this to the Release 1.32 milestone Aug 7, 2023
@lballabio
Copy link
Owner

Thanks! I just made a couple of other changes that jumped at me when I looked at the PR.

I wouldn't put too much effort into modernizing the library per se. We're changing things often enough in there that we can add some autos here and there as we already work on some files.

@lballabio lballabio merged commit d1b43b8 into lballabio:master Aug 7, 2023
48 checks passed
@sweemer sweemer deleted the modernize-examples branch August 7, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants