Separate validation from benchmarking run #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lballabio
reviewed
Jul 15, 2024
|
@klausspanderen I've tried to address your observations in this PR, please take a look and let me know. I do now get constant throughput when --nProc=1 regardless of --nSize. |
Validation run has very different characteristics from benchmarking run. This produced unintuitive scaling results as number of threads was kept fixed and problem size increased. This patch separates validation from benchmarking and ensures that validation time does not affect the benchmark results
amd-jadutoit
force-pushed
the
jdt-new-benchmark
branch
from
1a1a50c
to
47aa913
Compare
|
I've rebased on top of v1.35rc tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validation run has very different characteristics from benchmarking
run. This produced unintuitive scaling results as number of threads
was kept fixed and problem size increased.
This patch separates validation from benchmarking and ensures that
validation time does not affect the benchmark results. Benchmark now
reports consistent throughput for --nProc=1 as --size increases from 1
to 2 to 3 etc. When nProc>1, throughput stabilises as soon as the tail
effect ratio is high enough.