Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Output using hdmf-ml schema #43

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

[WIP] Output using hdmf-ml schema #43

wants to merge 15 commits into from

Conversation

rly
Copy link
Collaborator

@rly rly commented Oct 14, 2021

Within infer.py::in_memory_inference, output using the hdmf-ml structure ResultsTable instead of into a raw HDF5 file.

@ajtritt it looks like there is no longer code specific to handling the cases when args.classify == True or args.umap == True. Are these use cases no longer used?

@ajtritt
Copy link
Collaborator

ajtritt commented Oct 14, 2021

@ajtritt it looks like there is no longer code specific to handling the cases when args.classify == True or args.umap == True. Are these use cases no longer used?

Correct, these are no longer used. Running UMAP (i.e args.umap) requires an n^2 operation, so needs to be handled more delicately, so I stopped doing it here. We're always doing classification now (as opposed regression), so it's no longer necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants