-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend markdown support for LBRY urls #2521
Conversation
This is awesome! |
Hey @btzr-io! Sorry I lost track of this one. Do you have any urls I can test this at? |
@seanyesmunt Here is a claim with examples for all the new features:
But you can see some real examples already working here: Mentions for channels: I think this is a good example of this feature but you could also mention a friend's channel or another channel you own:
Auto-embed lbry urls
|
Also I still need to find a way to let the user choose if the auto-embed feature should apply for a specific link. I think discord has a syntax for this:
But this don't work on inline links like this |
Cool. I'll mess around with those links. Let me know when you would like me to review this PR. |
I found a plugin for custom props, now we can block the
|
@seanyesmunt Ok, is ready for review: Also let me know if you notice any performance or loading time issues ( can't confirm nothing yet ) |
Can you try to use https://ui.reach.tech/tooltip/? I was planning to use this for the regular tooltips. It has great keyboard/accessibility support. If it looks like a lot of trouble don't worry about it. |
@seanyesmunt ready for review ✌️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ended up adding reach/tooltip to the branch I'm working on. I used the ClaimListItem
component (i'm going to rename to ClaimPreview
) and added the tooltip in just a couple lines.
I really like what you did with your channel tooltip, but to keep development simpler in the future I'm going to just use this ^ for now.
Everything else looks good. I can merge once the tooltip stuff is removed.
@seanyesmunt Ok done 👍 |
yeah that looks better and clean 👍 💯 |
PR Checklist
Please check all that apply to this PR using "x":
PR Type
What kind of change does this PR introduce?
Fixes
lbry://
hyperlinks in description automatically create lbry:// hyperlinks in description #2229Changes
Automatically generated links
@channel
->[@channel](lbry://@chanel)
@channel/claim
->[@channel/claim](lbry://@channel/claim)
lbry://claim#e
->[lbry://claim#e](lbry://claim#e)
Todo