Skip to content

Commit

Permalink
Remove FIXME comment that no longer applies
Browse files Browse the repository at this point in the history
Changed code to use sub-class of Person instead of Person to avoid the problem where Person was already created with a different base_uri.
  • Loading branch information
elrayle committed Oct 28, 2014
1 parent d421ad6 commit 4280986
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
3 changes: 1 addition & 2 deletions spec/ld4l/foaf_rdf/configuration_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ class DummyPerson < LD4L::FoafRDF::Person
end
end


it "should return value of configured base_uri" do
LD4L::FoafRDF.configure do |config|
config.base_uri = "http://localhost/test_config/"
Expand Down Expand Up @@ -84,6 +83,7 @@ class DummyPerson < LD4L::FoafRDF::Person
end
end


describe "LD4L::FoafRDF::Configuration" do
describe "#base_uri" do
it "should default to localhost" do
Expand All @@ -105,5 +105,4 @@ class DummyPerson < LD4L::FoafRDF::Person
end
end
end

end
1 change: 0 additions & 1 deletion spec/ld4l/foaf_rdf_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ class DummyPerson < LD4L::FoafRDF::Person
end

it "should use configured value in Person sub-class" do
# FIXME fails if run with all tests because LD4L::FoafRDF::Person is already loaded by other tests with a different base_uri
p = DummyPerson.new('1')
expect(p.rdf_subject.to_s).to eq "http://localhost/test/1"
end
Expand Down

0 comments on commit 4280986

Please sign in to comment.