Merge pull request #4644 from kinke/cirrus_hacks

Cirrus CI & GHA: Revise test exclusion FIXMEs

.cirrus.yml

@@ -39,8 +39,6 @@ common_steps_template: &COMMON_STEPS_TEMPLATE
         # FIXME: the following tests fail
         rm $CIRRUS_WORKING_DIR/tests/debuginfo/nested_gdb.d
         rm $CIRRUS_WORKING_DIR/tests/sanitizers/fuzz_basic.d
-        # the following 2 have regressed with LLVM 13
-        rm $CIRRUS_WORKING_DIR/tests/sanitizers/msan_{noerror,uninitialized}.d
       fi
       python3 runlit.py -v -j $PARALLELISM .
     run_dmd_testsuite_script: |
@@ -50,17 +48,14 @@ common_steps_template: &COMMON_STEPS_TEMPLATE
       # Run defaultlib unittests & druntime integration tests
       cd $CIRRUS_WORKING_DIR/../build
       excludes="dmd-testsuite|ldc2-unittest|lit-tests"
-      if [[ "$CI_OS" == "freebsd" ]]; then
-        # FIXME: unittest failure for unclear reason
-        excludes+='|^std.experimental.allocator-shared$'
-      elif [[ "$CI_OS-$CI_ARCH" == "linux-aarch64" ]]; then
+      if [[ "$CI_OS-$CI_ARCH" == "linux-aarch64" ]]; then
         # FIXME: segfaults with enabled optimizations
         excludes+='|^core.thread.fiber(-shared)?$'
         # FIXME: failing unittest(s)
         excludes+='|^std.internal.math.gammafunction'
         # FIXME: failing unittest(s) with enabled optimizations
         excludes+='|^std.math.exponential(-shared)?$'
-        # FIXME: failure
+        # FIXME: subtest rt_trap_exceptions fails
         excludes+='|^druntime-test-exceptions-debug$'
         # std.path unittests apparently need HOME, which happens not to be set
         export HOME=~

.github/actions/4b-test-lit/action.yml

@@ -17,17 +17,10 @@ runs:
       shell: cmd
       run: |
         echo on
-        :: * strings_cdb has regressed for 32-bit starting with the VS 2019 v16.6.0 Azure Image (worked fine until v16.5.4)
-        ::   it also works fine on my box with the same v16.7.2...
-        :: * msvc_dwarf spuriously hits LLD assertions with v13.* and v14.0.0
+        :: FIXME: strings_cdb has regressed for 32-bit starting with the VS 2019 v16.6.0 Azure Image (worked fine until v16.5.4)
+        ::        it also works fine on my box with the same v16.7.2...
         if "${{ inputs.arch }}" == "x86" (
           del tests\debuginfo\strings_cdb.d || exit /b
-          del tests\debuginfo\msvc_dwarf.d || exit /b
-        )
-        :: FIXME: all ASan tests on Win64 regressed with the VS 2022 v17.9 image (worked fine until v17.8)
-        ::        (probably https://github.com/llvm/llvm-project/issues/82450)
-        if "${{ inputs.arch }}" == "x64" (
-          del tests\sanitizers\*asan* || exit /b
         )
         call "%LDC_VSDIR%\Common7\Tools\VsDevCmd.bat" -arch=${{ inputs.arch }} || exit /b
         echo on

.github/workflows/main.yml

@@ -67,7 +67,7 @@ jobs:
             bootstrap_cmake_flags: -DBUILD_LTO_LIBS=ON
             extra_cmake_flags: >-
               -DBUILD_LTO_LIBS=ON
-            # Undefined symbol errors with FullLTO; ThinLTO used to work, but apparently miscompiles a lexer.d:130 assertion since v1.33.
+            # Undefined symbol errors with FullLTO; ThinLTO used to work, but apparently miscompiles a lexer.d:138 assertion since v1.33.
             #  "-DD_COMPILER_FLAGS=-O -flto=thin -defaultlib=phobos2-ldc-lto,druntime-ldc-lto"
             #  -DEXTRA_CXXFLAGS=-flto=thin
             with_pgo: true

.github/workflows/supported_llvm_versions.yml

@@ -179,9 +179,11 @@ jobs:
           excludes='dmd-testsuite|lit-tests|ldc2-unittest'
           if [[ '${{ runner.os }}' == macOS ]]; then
             N=$(sysctl -n hw.logicalcpu)
-            # FIXME: fails with enabled optimizations on M1 runners
             if [[ '${{ matrix.os }}' == macos-14 ]]; then
+              # FIXME: crashes frequently with enabled optimizations on M1 runners
               excludes+='|^std.internal.math.gammafunction(-shared)?$'
+              # FIXME: sporadically segfaults with enabled optimizations
+              excludes+='|^core.thread.fiber(-shared)?$'
             fi
           else
             N=$(nproc)