Prevent snapcraft patching RPATH for library dependencies #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default snapcraft will rewrite the RPATH of binaries to link against libraries in the core snap. However, the prebuilt binaries used in the LDC package are designed and expected to link against host system libs. To allow them to do this we need to explicitly instruct snapcraft using the `no-patchelf` build attribute. For background see: https://forum.snapcraft.io/t/librt-so-1-undefined-symbol-clock-nanosleep/16246/2 This should allow LTO builds with LDC >= 1.21.0 to work on more recent systems (e.g. Ubuntu 20.04+). Fixes ldc-developers#121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default snapcraft will rewrite the RPATH of binaries to link against libraries in the core snap. However, the prebuilt binaries used in the LDC package are designed and expected to link against host system libs. To allow them to do this we need to explicitly instruct snapcraft using the
no-patchelfbuild attribute.For background see: https://forum.snapcraft.io/t/librt-so-1-undefined-symbol-clock-nanosleep/16246/2
This should allow LTO builds with LDC >= 1.21.0 to work on more recent systems (e.g. Ubuntu 20.04+).
Fixes #121