Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Leaderboard Endpoint #253

Merged
merged 14 commits into from
Oct 28, 2024

Conversation

TheTedder
Copy link
Contributor

Closes #231. I chose to make the return type of the method on the service not specific to LBs so that we can reuse it.

@TheTedder TheTedder marked this pull request as ready for review October 19, 2024 20:12
@TheTedder TheTedder requested a review from a team as a code owner October 19, 2024 20:12
Copy link
Contributor

@Eein Eein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

If you feel like it maybe a test for invalid type (guid as id)

@TheTedder TheTedder requested a review from zysim October 28, 2024 02:40
@TheTedder TheTedder merged commit 08f8b06 into leaderboardsgg:main Oct 28, 2024
2 checks passed
@TheTedder TheTedder deleted the delete-lb-endpoint branch October 28, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete Leaderboard Endpoint
3 participants