Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node to version 20 #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update Node to version 20 #45

wants to merge 1 commit into from

Conversation

Rathoz
Copy link

@Rathoz Rathoz commented Mar 14, 2024

@britzl
Copy link

britzl commented Apr 23, 2024

@alerque may I ask when this will be merged?

@alerque
Copy link

alerque commented Apr 23, 2024

@britzl I'm all for it but this is @leafo's project and I haven't been grated any special collaborator permissions so my approval doesn't count for much except to say I've had a look at it and think it's a good thing.

@britzl
Copy link

britzl commented Apr 23, 2024

@britzl I'm all for it but this is @leafo's project and I haven't been grated any special collaborator permissions so my approval doesn't count for much except to say I've had a look at it and think it's a good thing.

Ah, I see. I thought you were one of the maintainers. Have you tested it on a fork to verify that it is indeed working or only looked through the changes?

@alerque
Copy link

alerque commented Apr 24, 2024

I believe I did, but it's been a minute. It's pretty easy to do your self if you want to verify this as an extra data point for @leafo (and/or just make use of it until it merges). You just have to change the name of the step in your own workflow to the fork behind this PR and use the patch-1 branch for the version.

@BreakBB
Copy link

BreakBB commented May 14, 2024

This will fix #42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants