SESSION_REDIRECT_ON_REGISTER

[milosPavic]

SESSION_REDIRECT_ON_REGISTER need to be implemented, so that we can send activation email or to do other jobs.

Description

Related Issue

[crosa7]

Hey! Thank you for the contribution!
Can you add this configuration default value as well please (default values are in Core class)? And could you also provide a test for this change? Thanks a lot!

[milosPavic]

I add configuration value but for test i need to know how and where to do that need to dig inside.I just edit online things with GitHub i don't have it on my computer :) Milos On Tuesday, November 7, 2023 at 06:43:14 PM GMT+1, André Rosa ***@***.***> wrote: Hey! Thank you for the contribution! Can you add this configuration default value as well please? And could you also provide a test for this change? Thanks a lot! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[crosa7]

I add configuration value but for test i need to know how and where to do that need to dig inside.I just edit online things with GitHub i don't have it on my computer :) Milos On Tuesday, November 7, 2023 at 06:43:14 PM GMT+1, André Rosa @.> wrote: Hey! Thank you for the contribution! Can you add this configuration default value as well please? And could you also provide a test for this change? Thanks a lot! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>

All tests are inside the /tests folder, but for this you would need to clone it to your computer yes, and setup a database with a simple users table so that the tests can run against that database

[crosa7]

I add configuration value but for test i need to know how and where to do that need to dig inside.I just edit online things with GitHub i don't have it on my computer :) Milos On Tuesday, November 7, 2023 at 06:43:14 PM GMT+1, André Rosa @.> wrote: Hey! Thank you for the contribution! Can you add this configuration default value as well please? And could you also provide a test for this change? Thanks a lot! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.>

But to make it easier feel free to just add the missing default configuration to Core.php. When I have some time I can then later add the test. When you add the missing config I will then request a code review from Michael

[milosPavic]

Hollai have bunch of job on my side im making website on my side with leaf, i wont be able to do that soon. On Wednesday, November 8, 2023 at 09:48:27 PM GMT+1, André Rosa ***@***.***> wrote: I add configuration value but for test i need to know how and where to do that need to dig inside.I just edit online things with GitHub i don't have it on my computer :) Milos On Tuesday, November 7, 2023 at 06:43:14 PM GMT+1, André Rosa @.> wrote: Hey! Thank you for the contribution! Can you add this configuration default value as well please? And could you also provide a test for this change? Thanks a lot! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.> But to make it easier feel free to just add the missing default configuration to Core.php. When I have some time I can then later add the test. When you add the missing config I will then request a code review from Michael — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>