-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
huangliling
committed
Jun 28, 2024
1 parent
acba3e2
commit dc5628e
Showing
2 changed files
with
4 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dc5628e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改动没同步到
setup.py
里,对实际用户不生效吧?dc5628e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确实是遗漏了。但是另外一方面,这里是为了面向多版本 python 测试能够 pass 。如果要锁定依赖的话,就得按照多个 python 版本的最大子集去锁定,那样的话会不会和用户依赖的 requests/urllib 版本冲突呢?大佬有什么建议吗?
dc5628e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
可以通过 marker 指定不同版本的依赖,参考:https://github.com/Thriftpy/thriftpy2/blob/5b319bd5138b32ebc27a63acd74e9a9331465f4b/setup.py#L16-L17 ,在 requirements.txt 和 setup.py 里都可以用。
dc5628e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
学到了,我来提个修复