Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cid 3846 handle multiple pod in k8s #75

Merged

Conversation

henriq-amaral-leanix
Copy link
Contributor

@henriq-amaral-leanix henriq-amaral-leanix commented Jan 24, 2025

πŸ›  Changes made

This PR we moved the full scan to App Ready Event and modified the retry mechanism to wait 5 seconds

✨ Type of change

  • New feature (non-breaking change which adds functionality)

πŸ§ͺ How Has This Been Tested?

  • Unit tests

🏎 Checklist:

  • My code follows the style guidelines
  • I have performed a self-review of my own code
  • My commit message clearly reflects the changes made
  • Assigned the appropriate labels (version, PR type, etc.)

@henriq-amaral-leanix henriq-amaral-leanix added the enhancement New feature or request label Jan 24, 2025
@henriq-amaral-leanix henriq-amaral-leanix self-assigned this Jan 24, 2025
@henriq-amaral-leanix henriq-amaral-leanix requested a review from a team as a code owner January 24, 2025 10:15
Copy link

LeanIX GitHub Agent Code Coverage

File Coverage [83.67%] 🍏
ApplicationReadyListener.kt 83.67% 🍏
Total Project Coverage 71.54% 🍏

@mohamedlajmileanix
Copy link
Contributor

@henriq-amaral-leanix thanks for this, also have you tried to run the agent with issues (e.g. no configuration) and if that affects how long for the app to be ready? (to check if we missed anything else)

@henriq-amaral-leanix
Copy link
Contributor Author

have you tried to run the agent with issues (e.g. no configuration) and if

Hi @mohamedlajmileanix,
Yes, I've tried running the agent with issues, and it doesn't affect the application's readiness. This is because we will only attempt to connect to the server and perform the full scan after the agent is ready.

@henriq-amaral-leanix henriq-amaral-leanix merged commit 1b80a99 into main Jan 24, 2025
4 checks passed
@henriq-amaral-leanix henriq-amaral-leanix temporarily deployed to ghcr:leanix-github-agent January 24, 2025 11:39 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants