Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable lint in CI #155

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

chore: enable lint in CI #155

wants to merge 4 commits into from

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Aug 22, 2024

After cleaning up some unused arguments in #154, this proposes that all remaining linting problems go in nolints.json, and we enable the linter in CI.

@JLimperg
Copy link
Collaborator

Is there a way to disable certain linters? I'm in favour of enabling linting, but I don't plan to systematically document Aesop, so I wouldn't want to fight the docBlame linter all the time.

@kim-em
Copy link
Collaborator Author

kim-em commented Aug 23, 2024

Hmm, as far as I'm aware there isn't a way to turn off environment linters via runLinter.

@digama0 or @adomani, any ideas for how we could let people turn off e.g. docBlame easily from a lakefile? We either need more command line arguments for runLinter, or have the environment linter framework pay attention to a package level option?

@josojo
Copy link

josojo commented Oct 15, 2024

Others have done it like this:
https://plmlab.math.cnrs.fr/nuccio/mathlib4/-/blob/splittingfieldch/Mathlib/Data/FP/Basic.lean?ref_type=heads#L164

not sure whether this is good enough...

@kim-em
Copy link
Collaborator Author

kim-em commented Oct 16, 2024

Others have done it like this: https://plmlab.math.cnrs.fr/nuccio/mathlib4/-/blob/splittingfieldch/Mathlib/Data/FP/Basic.lean?ref_type=heads#L164

not sure whether this is good enough...

These are syntax linters, rather than environment linters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants